Skip to content
Snippets Groups Projects
Verified Commit b67a372e authored by Sofiane Lasri's avatar Sofiane Lasri
Browse files

feat: refactor TermsSectionController to improve active status handling

- Simplified the creation of TermsSection by directly setting 'active' to false and moved the active status update logic to a separate private method.
- Updated the logic for updating the active status of existing sections when creating and editing a section, improving code readability and maintainability.
parent b92966cc
Branches
No related tags found
1 merge request!55Resolve "Ajouter conditions générales de vente"
Pipeline #1002 passed
......@@ -81,15 +81,14 @@ public function store(Request $request): RedirectResponse
'text' => $request->input('content'),
]);
if ($request->has('active')) {
TermsSection::query()->update(['active' => false]);
}
TermsSection::create([
$section = TermsSection::create([
'content_translation_key_id' => $contentTranslationKey->id,
'active' => $request->has('active'),
'active' => false,
]);
$this->updateActiveStatus($section, $request->has('active'));
$section->save();
return redirect()->route('admin.terms.index')->with('success', 'Section créée avec succès.');
}
......@@ -108,13 +107,7 @@ public function update(Request $request, int $id): RedirectResponse
['text' => $request->input('content')]
);
if ($request->has('active')) {
TermsSection::where('id', '!=', $section->id)->update(['active' => false]);
$section->active = true;
} else {
$section->active = false;
}
$this->updateActiveStatus($section, $request->has('active'));
$section->save();
return redirect()->route('admin.terms.edit', [
......@@ -130,4 +123,14 @@ public function delete(int $id): RedirectResponse
return redirect()->route('admin.terms.index')->with('success', 'Section supprimée avec succès.');
}
private function updateActiveStatus(TermsSection $section, bool $active): void
{
if ($active) {
TermsSection::where('id', '!=', $section->id)->update(['active' => false]);
$section->active = true;
} else {
$section->active = false;
}
}
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment